Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to ecto 3.5 #13

Merged
merged 1 commit into from
Oct 20, 2020
Merged

Upgrade to ecto 3.5 #13

merged 1 commit into from
Oct 20, 2020

Conversation

drewolson
Copy link

@drewolson drewolson commented Oct 15, 2020

This pull request updates the library to work with ecto 3.5. I also took the liberty of upgrading the dependencies for testing.

I believe the changes should work with ecto pre and post 3.5.

Let me know what you think.

@drewolson
Copy link
Author

Unfortunately, excoveralls seems to think the coverage has dropped because it deems one less line "relevant" after the upgrade. There's still just a single line that is not covered, the same line as before this change.

@drewolson
Copy link
Author

@danielberkompas any chance on merging this in? It seems a lot of folks are having the same issues and it would be a shame for people to be working off their own forks. We're really loving cloak_ecto and would love to get these changes back into the main repo.

@danielberkompas
Copy link
Owner

This looks great! Thanks for the PR. I'll merge it in.

@danielberkompas danielberkompas merged commit 2238af0 into danielberkompas:master Oct 20, 2020
@danielberkompas
Copy link
Owner

@drewolson I released cloak_ecto version 1.1.0 with this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants