Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Fax resource #119

Merged
merged 2 commits into from
Jun 14, 2019
Merged

Add Fax resource #119

merged 2 commits into from
Jun 14, 2019

Conversation

schneiderderek
Copy link
Contributor

@schneiderderek schneiderderek commented Jun 11, 2019 •
edited
Loading

Overview

Mostly straightforward, adding the faxing endpoint to ex_twilio according to their API docs here: https://www.twilio.com/docs/fax/quickstart

Outstanding Questions/TODOs

  • Testing? I don't see much testing for individual resources. Did I miss them somewhere?
  • See if Travis CI passes

Derek Schneider added 2 commits June 11, 2019 01:28
Add Fax module to match API docs
8fdc862 
- Add fax url to config and add to url generator
Add note about API being in public beta
3ac6961
@danielberkompas
Copy link
Owner

You're right about tests. I haven't figured out a good way to test Twilio resources because it would be hard to share account credentials (which would be needed to run the tests) with other open source contributors.

@danielberkompas danielberkompas merged commit f35ddf9 into danielberkompas:master Jun 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@schneiderderek @danielberkompas