Add new fields to incoming phone number resources #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also changed the order to match the alphabetical order in the documentation to simplify things a bit, since Elixir structs are built on top of maps and ordering shouldn't be important
Update from upstream, add missing fields
|
Seems like you need to run the formatter @ferd Awesome to see you contributing to this project! |
Just removed the comment. Turns out the field is used, just not documented in the Twilio docs.
|
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also reordered them (hopefully not a problem?) to better align with the documentation value, making it easier to maintain the lists of fields in the future.