Refactor stream function, remove list functions
#14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extract the complex `stream` method in the Api module to a `ResultStream` module where it can have room to breath.
The list functions are not needed now that we have a good `ResultStream`. There really isn’t a reason why you would prefer to use the old paginated list api.
This is for consistency with the other function in `Parser`, `parse/2`. It also makes it much easier to chain.
danielberkompas
added a commit
that referenced
this pull request
Jun 8, 2015
Refactor `stream` function, remove list functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ExTwilio.Api.stream/2function has now become theExTwilio.ResultStreammodule. The code is a lot more readable as a result.With this nice
ResultStreammodule in place, we don't really need the oldlistfunctions, since there's really no reason to interact with the paginated api directly. All the filtering that you could do can be done throughResultStream, and it provides a safer, more efficient interface.