pin Poison dependency to >= 1.4 and < 2 #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit, the Poison dependency was pinned to anything in the 1.4.x series; however, given that Poison follows semantic versioning, we should pin to 1.x (where x >= 4) instead. This will allow compatability for dependency resolution when bundled with other projects that may require a newer version of Poison, such as Phoenix.
|
Looks good to me! Thanks for the PR. |
danielberkompas
added a commit
that referenced
this pull request
Sep 20, 2015
pin Poison dependency to >= 1.4 and < 2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, the Poison dependency was pinned to anything in
the 1.4.x series; however, given that Poison follows semantic
versioning, we should pin to 1.x (where x >= 4) instead. This will allow
compatibility for dependency resolution when bundled with other projects
that may require a newer version of Poison, such as Phoenix.