Add lookup rest api #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielberkompas
requested changes
Sep 16, 2016
|
|
||
| - [Twilio docs](https://www.twilio.com/docs/api/lookups) | ||
| """ | ||
| alias ExTwilio.{Parser, Api, Config} |
There was a problem hiding this comment.
You don't use the Api module, I don't think. So, no need to alias it here.
| national_format: nil, | ||
| phone_number: nil, | ||
| country_code: nil, | ||
| add_ons: nil |
There was a problem hiding this comment.
I think I would rather see this struct nested inside a submodule, like this:
defmodule PhoneNumber do
defstruct url: nil,
carrier: nil,
national_format: nil,
phone_number: nil,
country_code: nil,
add_ons: nil
endThis way, a list of ExTwilio.Lookup.PhoneNumber structs could be returned rather than a list of ExTwilio.Lookup structs.
|
|
||
| "#{@base_url}#{phone_number}#{query_string}" | ||
| |> HTTPoison.get!([], [hackney: auth]) | ||
| |> Parser.parse(__MODULE__) |
There was a problem hiding this comment.
After nesting the struct under a submodule, you would need to update this to:
|> Parser.parse(PhoneNumber)
|
Should be good to go now. Thanks! |
danielberkompas
approved these changes
Sep 16, 2016
|
⭐ ⭐ ⭐ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merges ex_twilio_lookup into ex_twilio. Thanks for the help @danielberkompas