Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instructions for receiving a call in the calling tutorial #54

Merged

Conversation

joshuafleck
Copy link
Contributor

Hi @danielberkompas - I've implemented the instructions for receiving a call with Twilio that I'd previously left as Pending... in CALLING_TUTORIAL.md.

Also, I did some minor refactoring to the Capability module as suggested by @pdawczak

Joshua Fleck added 2 commits September 30, 2016 16:18
There were a few stylistic errors with my last change that I wanted to correct, namely using the 't' convention for the name of the module struct, not referencing the name of the module directly within the module, and correctly indenting pipelines.
The calling tutorial now provides instructions for receiving a call in the browser

Once you've started your web server, you can expose your endpoint to the world with a tool like [Ngrok](https://ngrok.com/), pointing it to your development server on port 4000

`ngrok http 4000`
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would that make it a little bit clearer to people with no experience with ngrok, if this was formatted like CLI command?

Something like:

$ ngrok http 4000

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch @pdawczak - I've sorted this in 0bd7824

@danielberkompas danielberkompas merged commit 791b2e5 into danielberkompas:master Oct 24, 2016
@danielberkompas
Copy link
Owner

Thanks! @joshuafleck

⭐ ⭐

@joshuafleck joshuafleck deleted the enhance_calling_tutorial branch October 29, 2016 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants