Implement Task Router API #55
Conversation
|
@danielberkompas If I understand correctly |
|
@enilsen16 yes, that's correct. |
|
Alright, I need to go through and change some things before you merge this 😃 |
| @@ -64,6 +63,17 @@ defmodule ExTwilio.UrlGenerator do | |||
| end | |||
| end | |||
|
|
|||
| defp add_segements(url, module, id, options) do | |||
| @@ -158,7 +173,11 @@ defmodule ExTwilio.UrlGenerator do | |||
|
|
|||
| @spec infer_module(atom) :: atom | |||
| defp infer_module(atom) do | |||
There was a problem hiding this comment.
Could do this with pattern matching.
defp infer_module(:workspace), do: ExTwilio.TaskRouter.Workspace
defp infer_module(atom) do
Module.concat(ExTwilio, camelize(atom))
end
| @@ -0,0 +1,21 @@ | |||
| defmodule ExTwilio.TaskRouter.Activity do | |||
| @moduledoc """ | |||
| Repersents the current status of your workers. Workers can only have a single activity at a time. | |||
There was a problem hiding this comment.
Repersents -> Represents
| A Workspace is a container for your Tasks, Workers, TaskQueues, Workflows and Activities. | ||
| Each of these items exists within a single Workspace and will not be shared across Workspaces. | ||
|
|
||
| - [Twilio docs](https://www.twilio.com/docs/api/taskrouter/workflows) |
There was a problem hiding this comment.
I believe the link should be: https://www.twilio.com/docs/api/taskrouter/workspaces
|
|
||
| ## Example | ||
|
|
||
| Sets the auth token to be XXX |
There was a problem hiding this comment.
This should refer to worker sid
|
|
||
| ## Example | ||
|
|
||
| Sets the auth token to be XXX |
There was a problem hiding this comment.
This should refer to workspace sid
|
@enilsen16 is this still in progress? Need help with anything? |
|
I just haven't gotten around to finishing this (working on something else at work). I'll finish it this week though. Thanks @danielberkompas 😄 |
|
@danielberkompas Let me know if there's anything else you like me to add or change. 😄 |
|
@enilsen16 I'd like to see @joshuafleck's comments addressed and the build passing. |
|
Updated 😐 Dialyzer seems to be complaining. Any idea how to fix that error @danielberkompas? Thanks! |
|
I'll take care of the dialyzer warnings myself. Thanks! ⭐ |
This is most likely going to take me a few days to implement.
Let me know if there's anything you think I am missing @danielberkompas.