Add all endpoints for the programmable chat api. #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ents in submodules are specified to avoid the module inference potentially hooking the wrong modules. Further added some documentation to parents/0 and children/0 under ExTwilio.Resource so that understanding their roles are easier for future contributors
4141done
force-pushed
the
add-programmable-chat
branch
from
03fa6e8
to
6ad7a39
Compare
|
Very clean work. Thank you! ⭐️ ⭐️ ⭐️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Primary changes
Internal Changes
I ran into an issue where
infer_module/1couldn't be trusted to choose the correct module as submodules underExTwilioare added. I played with a few options before settling on the strategy of defining aExTwilio.Parentstruct and supplying parents in that format for any resources under a submodule. This makes sure that we are always guaranteed to use the correct module to determine the resource name at the expense of some slightly less pretty but more explicit parent definitions. TheUrlGeneratordeals with all parents consistently regardless of how they were specified so the original resources can maintain their format.Please let me know if you'd prefer a different strategy but this was what felt best to me in terms of maintaining how the package works and providing correctness.
Left to do