Fixing model file ownership permissions (#113)

danieldeutsch · Jan 23, 2022 · 167f68d · 167f68d
1 parent e50609e
commit 167f68d
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/models/lewis2020/Readme.md b/models/lewis2020/Readme.md
@@ -80,3 +80,7 @@ The CNN/DailyMail results are very close to those in the paper:
 
 - [ ] Predictions exactly replicate results reported in the paper  
 No, see above.
+
+## Changelog
+### v1.1
+- Fixed an issue with changing file ownership when the pre-trained model files were extracted.
diff --git a/models/lewis2020/scripts/download-models.sh b/models/lewis2020/scripts/download-models.sh
@@ -1,11 +1,11 @@
 if [ "$CNNDM" = "true" ]; then
   wget https://dl.fbaipublicfiles.com/fairseq/models/bart.large.cnn.tar.gz
-  tar -xvf bart.large.cnn.tar.gz
+  tar --no-same-owner -xvf bart.large.cnn.tar.gz
   rm bart.large.cnn.tar.gz
 fi
 
 if [ "$XSUM" = "true" ]; then
   wget https://dl.fbaipublicfiles.com/fairseq/models/bart.large.xsum.tar.gz
-  tar -xvf bart.large.xsum.tar.gz
+  tar --no-same-owner -xvf bart.large.xsum.tar.gz
   rm bart.large.xsum.tar.gz
 fi
diff --git a/repro/models/lewis2020/__init__.py b/repro/models/lewis2020/__init__.py
@@ -1,6 +1,6 @@
 import os
 
-VERSION = "1.0"
+VERSION = "1.1"
 MODEL_NAME = os.path.basename(os.path.dirname(__file__))
 DOCKERHUB_REPO = f"danieldeutsch/{MODEL_NAME}"
 DEFAULT_IMAGE = f"{DOCKERHUB_REPO}:{VERSION}"