Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow matching SHA256 fingerprint instead of SSH public key string #7

Merged
merged 2 commits into from
Oct 8, 2022

Conversation

dtinth
Copy link
Contributor

@dtinth dtinth commented Oct 6, 2022

GitHub now supports SSH commit verification. However, the string that gets shown in the verified badge is the SHA256 fingerprint of the public key, not the public key itself.

This PR adds a --fingerprint flag to allow matching against the fingerprint instead.

image

p.s. I am participating in Hacktoberfest, so if you choose to accept this PR, it would be really great if you can also add the hacktoberfest-accepted label to this PR.

@danielewood
Copy link
Owner

Thanks!
At first I was concerned with performance regressions, but there are none. Your changes are very welcome. Accepted and labeled with hacktoberfest-accepted.

@danielewood danielewood merged commit 39c8e55 into danielewood:master Oct 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants