Add keys per second display #8
Conversation
|
Playing with this in a long-running process (700 million so far at 134 k/s), the displayed key rate seems to respond very slowly to drastic changes in available cpu time, gradually stepping up or down by 0.01 k/s. I think this is because we’re calculating the average key rate over the whole run. What do you think about counting how many keys were processed since the last progress output, then dividing that by the time elapsed since that output (should be 0.25 s, but check monotonic time for accuracy)? |
|
That was my initial solution, but I had a look at a similar project and they did it this way, so i mimicked their behaviour. |
| // instead of starting at 0 and taking many seconds to tend towards the | ||
| // actual key rate | ||
| if oldCounter == 0 { | ||
| avgKeyRate = float64(global_counter) |
There was a problem hiding this comment.
every few runs, this hits a race condition and stays at 0. i figure this is fine, considering after a few seconds it tends towards the actual number anyways
|
alright, i've switched it to an exponential moving average |
|
I'm happy with the changes, I did a pretty major overhaul with optional json output, but I'll make sure to preserve your changes to the stdout that runs by default. |
This PR adds a display of the live keys/second.
In the second commit, I pull in a library to add commas into the
global_counterdisplay, if you don't want to add a dependency just for this i'm happy to get this merged without that commit!