Added CosmosClientOptions to UseCosmosDbPersistence method and CosmosClientFactory constructor #1062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ClientFactory constructor.
Added CosmosClientOptions to UseCosmosDbPersistence method and CosmosClientFactory constructor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the change
Added CosmosClientOptions to UseCosmosDbPersistence method and CosmosClientFactory constructor to pass additional configuration over to the CosmosClient.
Describe your implementation or design
Added CosmosClientOptions to UseCosmosDbPersistence method and CosmosClientFactory constructor with a default value of "null" so as not to break existing codebases.
Tests
N/A
Breaking change
No.
Additional context
By default, CosmosClient uses the "Direct" ConnectionMethod. This does not always work. To fix this, I wanted to pass the "ConnectionMethod" option. But looking at other providers "ElasticSearch", I saw that the configuration object for ElasticClient was passed to the DI methods. So, I used a similar approach here.