Add context to If When ForEach and UserTask #1095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@danielgerlag, could you please review this PR? |
|
@danielgerlag Would be really useful to get this in. |
danielgerlag
approved these changes
Mar 27, 2023
|
@IvanJosipovic can we get this merged? |
I don't have those super powers :p |
|
@danielgerlag Any chance we can this merged, and a release created? |
|
Yes, travelling at the moment. Will try this weekend. |
|
Thanks for merging @danielgerlag when will the new release be available on nuget? Looking at the actions, this still looks to be a manual step? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the change
Added new overloads for If/When/ForEach and UserTask with IStepExecutionContext
This allow using these tasks within a loop.
Solves: #599,#338
Describe your implementation or design
I copy/pasted the existing implementations and added IStepExecutionContext to the parameters.
Tests
No, let me know if they're needed.
Breaking change
No
Additional context
No