Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable supply of pre-provisoned AWS clients #1163

Merged

Conversation

stu-mck
Copy link
Contributor

@stu-mck stu-mck commented Apr 27, 2023

Describe the change
Added the option to provide an existing SQS client or Dynamo client rather than having the lock , persistence and queue providers creating them.

Describe your implementation or design
Added additional Service Collection extension methods to allow providing the clients. For default / current behaviour, the clients are now created in the extension method. For the new functionality, the client is passed into the extension method. The constructors on each of the providers has been altered receive the client rather than create it itself

Tests
No changes to functionality - only to how the objects are created

Breaking change
This is not a breaking change as the existing methods and signatures remain and work in the same way

Additional context
Using explicit AWS credentials in applications is not best practice as there are many ways in which these can be compromised. The encouraged practice is to execute your application in the context of an AWS role which will define the policies that the application is allow to execute. This approach does not use explicit credentials. Without this change, organisations that work in the encouraged manner cannot use the provided AWS lock, queue or persistence providers.

@danielgerlag danielgerlag merged commit b4e06ac into danielgerlag:master May 9, 2023
@stu-mck stu-mck deleted the allowPreProvisionedAWSClients branch May 16, 2023 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants