Handle typing collisions and add validation to a files module for overlaping declarations #582
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR builds off of the work here, addressing the issue I posted here: #580.
As mentioned by @scott-hendricks we encountered coliding imports when the k8s protos defined their own List class.
To address this I've added different options to execute the plugin to generate the import headers:
I have also added code to validate the generated modules for conflicts like the one above.
Important
This PR also fundamentaly changes how typing imports are loaded. Instead of trying to be prescriptive and see what imports we will need, the typing compiler tracks all calls that use it, including in the generation of the body of the Jinja Template, then seperatly generates the header and gathers all imports from what is actually used.
Checklist
Tests: