Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix badge URL #602

Merged
merged 1 commit into from
Aug 31, 2024
Merged

Fix badge URL #602

merged 1 commit into from
Aug 31, 2024

Conversation

AdrienVannson
Copy link
Contributor

Summary

The badge always shows the build as failing, even if it is actually successful.

This issue has been reported on actions/starter-workflows#1525 , and the fix suggested on actions/starter-workflows#1525 (comment) works.

Checklist

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes.
  • This PR fixes an issue.
  • This PR adds something new (e.g. new method or parameters).
    • This change has an associated test.
  • This PR is a breaking change (e.g. methods or parameters removed/renamed)
  • This PR is not a code change (e.g. documentation, README, ...)

The badge always shows the build as failing, even if it is actually successful.

This issue has been reported on actions/starter-workflows#1525 , and the fix suggested on actions/starter-workflows#1525 (comment) works.
@Gobot1234 Gobot1234 merged commit efaef50 into danielgtaylor:master Aug 31, 2024
19 checks passed
@AdrienVannson AdrienVannson deleted the patch-1 branch September 10, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants