fix: properly set error on panic recovery #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #168 +/- ##
=======================================
Coverage 74.88% 74.89%
=======================================
Files 25 25
Lines 3389 3390 +1
=======================================
+ Hits 2538 2539 +1
Misses 654 654
Partials 197 197
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #125, this bug prevented the error from getting returned which meant no non-zero exit code was ever set for panics. Now every panic should result in an exit code of 1.
I'm leaving the linked issue open because of the feature request for an option to exit non-zero for 3xx/4xx/5xx status codes for easier scripting.