For PNG images sometimes the internal logic would classify a single page #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plot as a multi-page plot, multi-page plots have a different file naming convention; the sole effect of this bug is that the filename will be different then expected. PGPLOT doesn't have this behaviour, so this bug will cause issues when using GIZA as a drop-in replacement for PGPLOT.
|
thanks for the fix - sorry for being slow to merge it! |
haavee
added a commit
to haavee/giza
that referenced
this pull request
Jul 26, 2022
The arrows looked markedly smaller in giza than on the PGPLOT original. Scaled them up a bit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
plot as a multi-page plot, multi-page plots have a different file naming
convention; the sole effect of this bug is that the filename will be
different then expected.
PGPLOT doesn't have this behaviour, so this bug will cause issues when using
GIZA as a drop-in replacement for PGPLOT.