Trying to pull the original repo to my fork #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running "docker build --rm -f FlushCrashApp.Dockerfile ." while in linux containers docker mode results in an error of "A callback was made on a garbage collected delegate of type 'RDotNet!RDotNet.Internals.Unix.ptr_R_FlushConsole::Invoke' "
This results in a app crashing when these callbacks get invoked later. Assigning the delegates to class fields ensures they don't get garbage collected.
Is not needed here and causes test command to fail. This causes warning: warning NU1701: Package 'xunit.runner.visualstudio 2.3.1' was restored using '.NETFramework,Version=v4.6.1' instead of the project target framework '.NETStandard,Version=v2.0'. This package may not be fully compatible with your project. and error: Catastrophic failure: System.TypeLoadException: Could not load type 'System.Runtime.Remoting.Channels.IChannel' from assembly 'mscorlib, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089'. at Xunit.RemotingUtility.CleanUpRegisteredChannels() at Xunit.Runner.VisualStudio.VsTestRunner.RunTests(IRunContext runContext, IFrameworkHandle frameworkHandle, LoggerHelper logger, TestPlatformContext testPlatformContext, Func`1 getRunInfos) in C:\Dev\xunit\xunit\src\xunit.runner.visualstudio\VsTestRunner.cs:line 395
Fix issue where callback delegates get garbage collected on linux
…ws. Unit tests may not have a repeatable behavior. Some can fail uncder VStudio test explorer.
…ologies # Conflicts: # RDotNet.TestBase/RDotNet.TestBase.csproj
…nuget dependencies. Found a workaround to #91.
…nuget package import.
(cherry picked from commit 41f7315)
…ed behavior in R
… for unknown reasons even after fresh checkout.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If I did something wrong, please ignore this request.