Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: show PR title in message #12

Merged
merged 1 commit into from
May 4, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/review_bot.rb
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
require_relative 'review_bot/extensions'
require_relative 'review_bot/reviewer'
require_relative 'review_bot/reminder'
require_relative 'review_bot/notification'

module ReviewBot
VERSION = '0.2.0'.freeze
Expand Down
28 changes: 28 additions & 0 deletions lib/review_bot/notification.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
# frozen_string_literal: true
module ReviewBot
class Notification
def initialize(pull_request:, suggested_reviewers:)
@pull_request = pull_request
@suggested_reviewers = suggested_reviewers
end

attr_reader :pull_request, :suggested_reviewers

def message
[needs_review_from, pull_request.html_url].join("\n")
end

private

def needs_review_from
[
%("#{pull_request.title}" needs a #{needed_review_type} from),
suggested_reviewers.map(&:slack_emoji).join(' ')
].join(' ')
end

def needed_review_type
pull_request.needs_first_review? ? 'first review' : 'second review'
end
end
end
16 changes: 4 additions & 12 deletions lib/review_bot/reminder.rb
Original file line number Diff line number Diff line change
Expand Up @@ -15,15 +15,8 @@ def message
return if notifications.empty?

# :smile_cat: https://github.com/danielma/reviewbot/pull/3 needs a first review from :dma: :dmas_evil_twin:
message = ":smile_cat: :wave:\n"
message + notifications.map do |notification|
[
"#{notification.pull_request.html_url} needs a",
notification.pull_request.needs_first_review? ? 'first review' : 'second review',
'from',
notification.suggested_reviewers.map { |r| ":#{r.slack}:" }.join(' ')
].join(' ')
end.join("\n\n")
message_header = ":smile_cat: :wave:\n"
message_header + notifications.map(&:message).join("\n\n")
end

def app_reviewers
Expand Down Expand Up @@ -56,10 +49,9 @@ def potential_notifications

next if suggested_reviewers.empty?

OpenStruct.new(
Notification.new(
pull_request: pull,
suggested_reviewers: suggested_reviewers,
work_hours_since_last_touch: work_hours_since_last_touch
suggested_reviewers: suggested_reviewers
)
end
end
Expand Down
4 changes: 4 additions & 0 deletions lib/review_bot/reviewer.rb
Original file line number Diff line number Diff line change
Expand Up @@ -12,5 +12,9 @@ def timezone
def work_hour?
HourOfDay.new(timezone.utc_to_local(Time.now.utc)).work_hour?
end

def slack_emoji
":#{slack}:"
end
end
end