-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rutie proc macros #145
Comments
cc @Hywan |
Hi! I wrote those macros. They aren't perfect, but they helped me on the short-term. I can dedicate some times to improve them if @danielpclark believes it can be useful for |
Can I have some clarification on what exactly is being proposed to be added and improved upon? Is it some of the written I'm open for improvements, macros, helpers, and the like. If you're wanting to just add macros that help with the ease of use in writing Ruby methods/objects feel free to place those in From the sound of it it may indeed be something we want in Rutie itself. |
I believe @dsisnero is talking about See a usage example, I've also defined a new If you find them useful, I can open a PR to integrate them inside Bonus: I've also used |
@Hywan excellent! Yes I like those. Feel free to add them to this project. |
I will try to find time to do that then! |
The macros must be polished. For example, it's not possible to support optional parameter, or named parameter for a function or a method for the moment. Do we want to migrate the macros, and polish them here in this repository, or do you prefer to get a fully polished version first? |
You can work on them here and polish them here. They don't have to be the best to go public, they just have to work. Those features you're describing that don't work yet can simply be a future update to this project. |
I'm working on a PR with migration. I've copied source files of Not sure it's the best approach. Currently fixing compilation errors. Maybe a better option is move @danielpclark @Hywan What do you think? |
Copied rutie-derive and rutie-derive-macros crates with Git history from https://github.com/wasmerio/wasmer-ruby. According to wasmerio/wasmer-ruby#55 and danielpclark#145.
wasmer-ruby wrote some proc proc macros - it would be good if these were integrated in rutie - haven't brought it up in the wasmer project yet.
wasmerio/wasmer-ruby#48
The text was updated successfully, but these errors were encountered: