This repository has been archived by the owner on Feb 4, 2024. It is now read-only.
support rx_mode #313
Merged
support rx_mode #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielperna84
added a commit
that referenced
this pull request
Aug 4, 2020
* Add support for HmIPW-Devices (DRD3, SPI, DRBL4) (#310) * Added support for HmIPW-DRD3, HmIPW-SPI and HmIPW-DRBL4 * Fix whitespace Co-authored-by: Daniel Perna <danielperna84@gmail.com> * support rx_mode (#313) * support rx_mode * fix whitespace * feat: added support for HB-UNI-RGB-LED-CTRL (https://github.com/jp112sdl/HB-UNI-RGB-LED-CTRL) (#315) Co-authored-by: Lukas Riegel <lukas.riegel@sap.com> * Pyhomematic/add/ipw key blind multi (#318) * Fixed work around for hm init issue * added callback call * remove comments * removed pmatic * fixed spacing * according to alignment in #318, listdevice and interface if statement changed * removed debug breakpoint setting * added more generic check: proxy._remoteport == [2010, 32010, 42010] * fixed proxy._remoteport in [2010, 32010, 42010] statement * Limit to HmIP * Remove whitespace * Home Assistant doesn't use createDeviceObjects * Change skipping mechanism * Fix syntax Co-authored-by: Daniel Perna <danielperna84@gmail.com> * Add sensornode for HmIP Covers * Update changelog * Bump version * Set https for json #311 Co-authored-by: P0L0 <1452110+p0l0@users.noreply.github.com> Co-authored-by: Steffen Rusitschka <rusitschka@users.noreply.github.com> Co-authored-by: lukasriegel <lukas-riegel@t-online.de> Co-authored-by: Lukas Riegel <lukas.riegel@sap.com> Co-authored-by: Matthias Weiss <matthias.h.weiss@arcor.de>
danielperna84
added a commit
that referenced
this pull request
Dec 13, 2020
* Add support for HmIPW-Devices (DRD3, SPI, DRBL4) (#310) * Added support for HmIPW-DRD3, HmIPW-SPI and HmIPW-DRBL4 * Fix whitespace Co-authored-by: Daniel Perna <danielperna84@gmail.com> * support rx_mode (#313) * support rx_mode * fix whitespace * feat: add device support for HmIP-DRSI1 Co-authored-by: P0L0 <1452110+p0l0@users.noreply.github.com> Co-authored-by: Daniel Perna <danielperna84@gmail.com> Co-authored-by: Steffen Rusitschka <rusitschka@users.noreply.github.com> Co-authored-by: Lukas Riegel <lukas.riegel@sap.com>
danielperna84
added a commit
that referenced
this pull request
Jan 1, 2021
* Homeassistant/improve/cover (#341) * enhanced device nameing * rmeoved unused var * Device Support for HmIP-DRSI1 (#356) * Add support for HmIPW-Devices (DRD3, SPI, DRBL4) (#310) * Added support for HmIPW-DRD3, HmIPW-SPI and HmIPW-DRBL4 * Fix whitespace Co-authored-by: Daniel Perna <danielperna84@gmail.com> * support rx_mode (#313) * support rx_mode * fix whitespace * feat: add device support for HmIP-DRSI1 Co-authored-by: P0L0 <1452110+p0l0@users.noreply.github.com> Co-authored-by: Daniel Perna <danielperna84@gmail.com> Co-authored-by: Steffen Rusitschka <rusitschka@users.noreply.github.com> Co-authored-by: Lukas Riegel <lukas.riegel@sap.com> * Update misc.py (#363) * Update misc.py Added support for Wall Mounted Switch WRCC2 * Update misc.py * Update misc.py Starting to feel a bit stupid now, but now it should be correct * Add sensornode for tilt position of HmIP Covers (#365) * Support for Bat Level and WRCC2 (#366) Added battery voltage helper to remote HmIP devices Added WRCC2 remote switch. All tested and working with WRC2 and WRCC2 * Adds inhibit param to supported devices. (#364) * Bump version, update changelog * Lint * Support for HmIP-FALMOT-C12 #367 * Add HmIP-SRD #347 * Add to dict #347 * Logging cleanup Co-authored-by: Matthias Weiss <matthias.weiss@posteo.de> Co-authored-by: lukasriegel <lukas-riegel@t-online.de> Co-authored-by: P0L0 <1452110+p0l0@users.noreply.github.com> Co-authored-by: Steffen Rusitschka <rusitschka@users.noreply.github.com> Co-authored-by: Lukas Riegel <lukas.riegel@sap.com> Co-authored-by: Remko76 <75678314+Remko76@users.noreply.github.com> Co-authored-by: Robin Blöhm <robin.bloehm@gmail.com> Co-authored-by: Patrick Hofmann <p.hofmann@afb-esolutions.de>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds support for submitting configuration data via putParamSet with different rx_mode settings for BidcosRF devices (not HmIP).
BidcosRF devices have a fourth parameter for putParamSet which defines the way the configuration data is sent to the device. See 4.2.7 in HM XML API.
rx_mode BURST, which is the default value, will wake up every device when submitting the configuration data and hence makes all devices use some battery. It is instant, i.e. the data is sent almost immediately.
rx_mode WAKEUP will send the configuration data only after a device submitted updated values to CCU, which usually happens every 3 minutes. It will not wake up every device and thus saves devices battery.
Using less bursts also reduces DutyCycle spikes, i.e. DutyCycle increasing to > 90% during 5-10 minutes or so. That is probably because of too aggressive retries. Since using WAKEUP only I haven't seen those DutyCycle spikes anymore.
I changed the method signature in a backwards compatible way using a default value. So this change shouldn't break any existing code.