Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support env SASL_USER_PASSWORD #442

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

wangzhiy
Copy link

No description provided.

@baonq-me
Copy link

baonq-me commented Dec 2, 2024

+1 for this PR

Authentication info can not be expose in process cmdline

65534    265563  0.5  0.0 1242340 12676 ?       Ssl  14:27   0:00 /bin/kafka_exporter --kafka.server=xxx:19092 --kafka.server=yyy:19092 --kafka.server=zzz:19092 --sasl.enabled --sasl.mechanism=scram-sha512 --tls.enabled --sasl.username=admin --sasl.password=DztTg3xxxxxxxxxx --tls.insecure-skip-tls-verify

Can you take a look @danielqsj ?

@cthu1hoo
Copy link

cthu1hoo commented Dec 9, 2024

please consider merging this, having password in process list, especially admin one as it is required to get all metrics, is not great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants