Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HTTP validateDomainName not supported anymore #2053

Closed
silkimen opened this issue Oct 20, 2017 · 2 comments
Closed

HTTP validateDomainName not supported anymore #2053

silkimen opened this issue Oct 20, 2017 · 2 comments

Comments

@silkimen
Copy link
Contributor

I'm submitting a ... (check one with "x")
[ ] bug report
[x ] feature request

Current behavior:
The ionic-native/http plugin does provide "validateDomainName" method, but I've removed this method in the cordova plugin (v1.6.2+).

Expected behavior:
Just remove this method in ionic-native/http.

I'll provide you an PR.
@silkimen silkimen mentioned this issue Oct 20, 2017
Merged
ihadeed pushed a commit that referenced this issue Nov 9, 2017
@silkimen @ihadeed
feat(http): add support for new methods (#2054)
d96d3ee 
* feat(http): add patch request support (#2052)

* feat(http): add "disableRedirect" support (#2022)

* fix(http): remove obsolete "validateDomainName" function (#2053)
@sykaeh
Copy link

sykaeh commented Nov 17, 2017

This issue has been resolved, hasn't it?

@silkimen
Copy link
Contributor Author

Yes, my PR was merged. Closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sykaeh @silkimen