feature(): Phonegap local notifications #1474
Conversation
In some plugins the typescript markup was missing.
I also unified the console.log string from console.log("hello") to console.log('Hello') so any plugin page look the same.
danielsogl
changed the title
|
Oh you picked a tricky plugin to be your first 😁 ... I personally think the plugin is poorly made (the actual plugin by phonegap). The way this wrapper needs to work is: declare var Notification: any;
// can use a shorter name here, like PLNObject ?
export class PhonegapLocalNotificationObject {
private _objectInstance: any;
// instance properties can go here, see https://github.com/phonegap/phonegap-plugin-local-notification/blob/master/www/notification.js#L23-L33
@CordovaProperty title: string;
@CordovaProperty dir: string;
@CordovaProperty lang: string;
constructor(title: string, options: any) {
if (checkCordovaAvailablity('Notification') === true) {
// if _objectInstance doesn't exist, nothing with the @CordovaInstance or @CordovaProperty decorator will work
this._objectInstance = new Notification(title, options);
}
}
@CordovaInstance({ sync: true })
close(): void { }
}
@Plugin({
...
})
@Injectable()
export class PhonegapLocalNotification {
create(title: string, options: any) { return new PhonegapLocalNotificationObject(title, options); }
@Cordova()
requestPermission(): Promise<any> { return; }
} |
|
Thank you for your quick reply. Can you explain how I can call the checkCordovaAvailablity method? |
|
Sorry it's Here's an example: https://github.com/driftyco/ionic-native/blob/master/src/%40ionic-native/plugins/google-maps/index.ts#L64 |
|
Okay fine. I changed it. Can you check the build errors so I or you can check this plugin? |
| * @param title {string} Title of the local notification. | ||
| * @param Options {LocalNotificationOptions} An object containing optional property/value pairs. | ||
| */ | ||
| @Cordova() |
There was a problem hiding this comment.
You need to remove this decorator because it will override the functionality you wrote
| /** | ||
| * closes an open notification. | ||
| */ | ||
| close(): void { } |
There was a problem hiding this comment.
Remove the close() method from here. It's an instance method, you already got it in PLNObject.
| * ``` | ||
| */ | ||
| @Plugin({ | ||
| pluginName: 'Phonegap Loca Notifications', |
There was a problem hiding this comment.
Got a typo here.. Loca -> Local
| import { Cordova, CordovaInstance, Plugin, IonicNativePlugin, checkAvailability } from '@ionic-native/core'; | ||
|
|
||
| declare var Notification: any; | ||
| // can use a shorter name here, like PLNObject ? |
|
@danielsogl what build errors? |
| } | ||
|
|
||
| /** | ||
| * @name phonegap-local-notifications |
There was a problem hiding this comment.
Name needs to be Phonegap Local Notification ... also directory name should be phonegap-local-notification
|
Thank you again. I talked about the build errors when I run npm run build. |
fix #1417