Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(google-maps): add missing features and fix wrong definitions #1815

Merged
merged 18 commits into from
Jul 21, 2017
Merged

feat(google-maps): add missing features and fix wrong definitions #1815

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
c7d1f23
Update index.ts
wf9a5m75 Jul 17, 2017
f20d61a
Update index.ts
wf9a5m75 Jul 17, 2017
17a06ec
Add missing features, and bug fix of methods
Jul 17, 2017
7dabc77
update: classname must be in pascal case
Jul 17, 2017
9897a1e
remove: duplicated class definition
Jul 17, 2017
c476025
export encode and spherical static classes
Jul 18, 2017
dde96b1
Add comma
Jul 18, 2017
ccee755
Fix Encoding and Spherical
ihadeed Jul 18, 2017
46127c0
Add convenience methods
ihadeed Jul 18, 2017
9216c00
Fix decorators for Encoding and Spherical
ihadeed Jul 18, 2017
1720dcc
Update: getMap() methods return the instance of the wrapper plugin
wf9a5m75 Jul 18, 2017
980f35d
Update: getMap() methods return the instance of the wrapper plugin
wf9a5m75 Jul 18, 2017
4b29aec
Remove `@CordovaInstance` decorators from getMap()
wf9a5m75 Jul 19, 2017
dd77ec4
Update: GoogleMapOptions (all fields are not optional).
wf9a5m75 Jul 19, 2017
93311ea
Follow up: version `2.0.0-beta2-20170719-2226` of cordova-plugin-goo…
wf9a5m75 Jul 20, 2017
2337316
Fix: tslint error
wf9a5m75 Jul 20, 2017
73a670b
Fix: tslint error
wf9a5m75 Jul 20, 2017
e679868
No more isAvailable() method.
Jul 20, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/@ionic-native/plugins/google-maps/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -712,11 +712,21 @@ export class BaseClass {
*/
export class Circle extends BaseClass {

constructor(_objectInstance: any) {
private _map: GoogleMap;

constructor(_map: GoogleMap, _objectInstance: any) {
super();
this._map = _map;
this._objectInstance = _objectInstance;
}

/**
* Return the map instance.
* @return {GoogleMap}
*/
@CordovaInstance({ sync: true })
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the @CordovaIntance decorator from the getMap methods.

Cordova, CordovaInstance, CordovaProperty and InstanceProperty decorators override your custom definition. Since you are defining your own functionality here, you have to remove the decorators.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you tell me how different each decorators Cordova, CordovaInstance, CordovaProperty and InstanceProperty?
Where should I read the document?

getMap(): any { return this._map; }

/**
* Change the center position.
* @param latLng {ILatLng}
Expand Down