Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nativegeocoder): change return type to array and add options param #2319

Merged
merged 12 commits into from
Jun 23, 2018
Merged

feat(nativegeocoder): change return type to array and add options param #2319

merged 12 commits into from
Jun 23, 2018

Conversation

sebastianbaar
Copy link
Contributor

For making the API more robust for future changes and new features I changed the return type of both methods to an array and added an 'options' param.

  • The result Object of nativegeocoder.reverseGeocode is an Array.
  • The result Object of nativegeocoder.forwardGeocode is an Array.
  • Add options param for both nativegeocoder.reverseGeocode and nativegeocoder.forwardGeocode for setting locale & max result objects

@danielsogl danielsogl added this to the 5.0.0 milestone Mar 19, 2018
@danielsogl danielsogl merged commit 9f662b6 into danielsogl:master Jun 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants