Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(web-intent): fix options param #2450

Merged
merged 3 commits into from
Apr 12, 2018
Merged

fix(web-intent): fix options param #2450

merged 3 commits into from
Apr 12, 2018

Conversation

mcelotti
Copy link
Contributor

fix(web-intent): fix options param for startService, sendBroadcast, startActivityForResult, startActivity

danielsogl
danielsogl requested changes Apr 12, 2018
View reviewed changes
Copy link
Owner

@danielsogl danielsogl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would recommend creating an interface for the options.

@mcelotti
Copy link
Contributor Author

Hi @danielsogl I've updated the code, thank you.

@mcelotti mcelotti mentioned this pull request Apr 12, 2018
Merged
@danielsogl danielsogl merged commit 23b760b into danielsogl:master Apr 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielsogl danielsogl danielsogl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mcelotti @danielsogl