Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(firebase-crashlytics): add new plugin #2889

Closed
wants to merge 13 commits into from

Conversation

niconaso
Copy link
Contributor

Here I publish a new firebase-crashlytics plugin.
You can delete the PR #2887 since I've accidentally lost my forked repo so I had to forked it again. Sorry for the inconvenience!

@danielsogl danielsogl self-assigned this Feb 14, 2019
@danielsogl danielsogl self-requested a review February 14, 2019 08:38
@danielsogl danielsogl added the target: minor This PR is targeted for the next minor release label Feb 14, 2019
Copy link
Owner

@danielsogl danielsogl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove changes from the package-lock.json

src/@ionic-native/core/decorators/common.ts Outdated Show resolved Hide resolved
Copy link
Owner

@danielsogl danielsogl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The package-lock.json changes are still there.

@niconaso
Copy link
Contributor Author

@danielsogl do you want me to remove the package-lock.json and push the change?

danielsogl added a commit that referenced this pull request Feb 14, 2019
danielsogl added a commit that referenced this pull request Feb 14, 2019
@danielsogl
Copy link
Owner

Done

@danielsogl danielsogl closed this Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs reply target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants