feat(spotify-auth): add Spotify OAuth plugin #2989
Conversation
|
Could you explain in 1-2 sentences what this does? Does it expose the cordova plugin as ionic plugin? If it's that, I think it might be a good idea to reexport the typings from our code instead of re-declaring them here to reduce duplication, but other than that, LGTM. |
lutangar
force-pushed
the
feat/spotify-auth
branch
from
92197cb
to
f6d87dc
Compare
Yes, this is what it does. It describes the plugin as an injectable service/object for angular.
Yeah I would love to do that, I don't know if's possible though. The explanations are not very thorough, and there is nothing on this specific matter. |
|
So normally you'd just add the project as dependency to the plugin and export the types using ESM syntax. |
| plugin: 'cordova-spotify-oauth', | ||
| pluginRef: 'cordova.plugins.spotifyAuth', | ||
| repo: 'https://github.com/Festify/cordova-spotify-oauth', | ||
| install: 'ionic cordova plugin add resgrid-cordova-plugins-rollbar --variable LOCAL_STORAGE_KEY="SpotifyOAuthData"', |
There was a problem hiding this comment.
What's resgrid-cordova-plugins-rollbar? Naively I'd say you'd want to install cordova-spotify-oauth here instead.
lutangar
force-pushed
the
feat/spotify-auth
branch
from
f6d87dc
to
114195a
Compare
Yeah definitely, but in the case of this project (ionic-native), the dependencies of a plugin seems to be handled via the Surely we could generate and push these declarations from the |
|
Oh well. Okay, then, I guess you can merge this now. |
|
Ping @danielsogl |
I'm not the maintainer of the cordova-spotify-oauth plugin.
So we should probably wait for @NeoLegends review/approval on this before merging anything.