Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes bug in readAsText() and adds readAsDataURL() in File plugin #346

Merged
merged 5 commits into from
Jul 22, 2016
Merged

Fixes bug in readAsText() and adds readAsDataURL() in File plugin #346

merged 5 commits into from
Jul 22, 2016

Commits on Jul 21, 2016

  1. Updates docs for CameraPreview, Base64ToGallery and Developer.MD 

    -DEVELOPER.md: Corrects 'npm run tslint' instruction to 'npm run lint'
-CameraPreview: Fixes syntax error in hide
-Base64ToGallery: Adds desc of options obj props
    @amuramoto
    amuramoto committed Jul 21, 2016
    Configuration menu
    Copy the full SHA
    e461530 View commit details
    Browse the repository at this point in the history

  2. Fixes resolveLocalFileSystemURL bug in File.readAsText() and adds Fil… 

    …e.readAsDataUrl()

- File.readAsText(): window.resolveLocalFileSystemURL() was incorrectly implemented
    @amuramoto
    amuramoto committed Jul 21, 2016
    Configuration menu
    Copy the full SHA
    99127ab View commit details
    Browse the repository at this point in the history

  3. Updates callback arg in File.checkFile() 

    Callback arg of window.resolveLocalFileSystemURL was fileSystem, but it actually returns fileEntry
    @amuramoto
    amuramoto committed Jul 21, 2016
    Configuration menu
    Copy the full SHA
    b3245e5 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' of github.com:driftyco/ionic-native

    @amuramoto
    amuramoto committed Jul 21, 2016
    Configuration menu
    Copy the full SHA
    47f997f View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2016

  1. Corrects repo link and comments out setFlashMode() 

    - Repo prop and link in desc were not pointing to the same gh repo as the plugin
- setFlashMode() is not currently available in the repo that gets pulled by the corodova plugin
    @amuramoto
    amuramoto committed Jul 22, 2016
    Configuration menu
    Copy the full SHA
    bcb7857 View commit details
    Browse the repository at this point in the history