Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(onesignal): update to match latest api #671

Merged
merged 1 commit into from
Oct 11, 2016
Merged

fix(onesignal): update to match latest api #671

merged 1 commit into from
Oct 11, 2016

Conversation

ihadeed
Copy link
Collaborator

@ihadeed ihadeed commented Oct 11, 2016

closes #667

@ihadeed ihadeed merged commit 7c6e6d8 into master Oct 11, 2016
@guidux
Copy link

guidux commented Oct 13, 2016

Hi Guys,

I am afraid that inFocusDisplaying is missing in src/plugins/onesignal.ts instead enableNotificationsWhenActive remains. Accordig to this upgrade guide from onesignal

enableInAppAlertNotification and enableNotificationsWhenActive have been combined into inFocusDisplaying which is set from the OneSignal.Builder.

@ramonornela
Copy link
Contributor

ramonornela commented Oct 13, 2016 •
edited
Loading

@guidux fix in babfb0d

Thanks

@ihadeed ihadeed deleted the fix-667 branch October 14, 2016 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anaganisk anaganisk anaganisk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Onesignal interfacing seems to be obsolete with Ionic 2
4 participants
@ihadeed @guidux @ramonornela @anaganisk