Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(app-preferences): add appPreferences plugin #906

Closed
wants to merge 1 commit into from
Closed

feat(app-preferences): add appPreferences plugin #906

wants to merge 1 commit into from

Conversation

thomashilzendegen
Copy link

No description provided.

Copy link
Collaborator

@ihadeed ihadeed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be only one of each functions.

fetch can be:

static fetch(dictOrKey: string, key?: string)

and store:

store(dictOrKey: string, keyOrValue: string, value?: string)

The documentation at the top should explain the different kind of usages.

@thomashilzendegen
Copy link
Author

@ihadeed: I see, but why shouldn't overloads be used? The IntelliSense looks quite nice with them.

@ihadeed
Copy link
Collaborator

ihadeed commented Dec 28, 2016

I agree the IntelliSense will look better, but overloading causes issues with the Ionic Native docs generator. Here is what the output of the docs looks like for that page:

store(dict, key, value, key, value)

Stores the provided value for the given key into the named dictionary.

Param Type Details
dict

string

 
key

string

 
value

*

Stores the provided value for the given key.

key

string

 
value

*

 

fetch(dict, key, key)

Retrieves the value for the given key from the named dictionary.

Param Type Details
dict

string

 
key

string

Retrieves the value for the given key.

key

string

 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants