Commits on Jan 22, 2017

1. Fix exception in CordovaProperty …

   This reverts part of commit 67adb23, which moved the call to getPlugin()
   from within CordovaProperty() to a point where it was called too early.
   
   When the CordovaProperty decorator is called on a property, the class
   containing that call has not yet had its Plugin decorator called. Only
   when the latter happens does pluginRef get set. Thus, attempting to
   access pluginRef within CordovaProperty at the time of the call will
   give undefined, and attemping to call getPlugin with an undefined value
   will throw an exception:
   
       Runtime Error
       Cannot read property 'split' of undefined
   
       TypeError: Cannot read property 'split' of undefined
           at get
           at getPlugin
           at CordovaProperty
           at __decorate
           ...
   
   The above message can be seen in the browser after running the 'ionic
   serve' command.
   
   This commit moves the getPlugin call back to the getters and setters
   established by CordovaProperty, which are only called *after* the Plugin
   decorator has finished executing.
   
   closes danielsogl#992

   

   peterkelly committed Jan 22, 2017
   Configuration menu

   • View commit details
   • Copy full SHA for cf4a080
   • Browse repository at this point

   Copy the full SHA

   cf4a080 View commit details

   Browse the repository at this point in the history