Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: removes module export #9

Merged
merged 1 commit into from
Aug 25, 2022
Merged

fix: removes module export #9

merged 1 commit into from
Aug 25, 2022

Conversation

andrew-w-ross
Copy link
Contributor

No description provided.

@andrew-w-ross
Copy link
Contributor Author

Might be worth adding two example projects, one commonjs and one esm. In your ci link both and see if it executes cleanly.

danielwaltz
danielwaltz approved these changes Aug 25, 2022
View reviewed changes
Copy link
Owner

@danielwaltz danielwaltz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for creating a fix, sad because I felt like we really had it figured out there. Sometimes working in the node ecosystem really is a game of whack-a-mole. 😆

@danielwaltz danielwaltz merged commit f44b5d6 into danielwaltz:main Aug 25, 2022
@github-actions
Copy link

🎉 This PR is included in version 2.2.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@andrew-w-ross
Copy link
Contributor Author

@danielwaltz Well in this case there are two issues outside of this project that need to be fixed before this can turned into a module. The graphql config issue I mentioned and this tsup issue.

@andrew-w-ross andrew-w-ross deleted the bugfix/undo-es-module branch August 26, 2022 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielwaltz danielwaltz danielwaltz approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrew-w-ross @danielwaltz