-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
image size optimization #529
Conversation
@ciotlosm could you review this? |
Tested. Good job 👍 |
@ciotlosm the build stopped working after this PR. Already tried reverting it but that didn't help. Do you know what is going on? |
Hey. I have been away for a while. I will review all items later today and get back to you |
@Koenkk the upload problem seems to be related to credentials. Maybe something wrong with @danielwelch docker hub credentials. The image was built just the upload fails. |
@G1K I think would be great if we could adopt some of your optimisations in https://github.com/zigbee2mqtt/hassio-zigbee2mqtt that will become the official add-on. I will try to create a PR, but please help review as well. |
It's a pity that there are problems with the publication of images. yes I will adapt, but a little later. Removing unused files (for example, via modclean) the size of all files together with node_modules is about 20 mb, the archive is 3-6 mb or combining all the code (for example, via https://github.com/vercel/ncc) into one file allows you to fit the project in 8 megabytes together with the frontend But for devices with docker and HomeAssistnt. I think it will be redundant |
@G1K I've included your changes here: zigbee2mqtt/hassio-zigbee2mqtt@0b07170 That's the reason we're trying to move to the "org" version of the add-on to allow more admins, in case someone is unavailable for a while. |
The size of the images will be reduced by about 2/3 of the size of ~ 400 MB.
Other possible improvements: