Skip to content
This repository has been archived by the owner on Jul 6, 2024. It is now read-only.

Commit

Permalink
Adding support for rdb_save & rdb_load (#26)
Browse files Browse the repository at this point in the history
  • Loading branch information
@danitseitlin
danitseitlin authored Mar 2, 2022
1 parent 90c922b commit 3240281
Show file tree
Hide file tree
Showing 9 changed files with 601 additions and 101 deletions.
10 changes: 10 additions & 0 deletions .github/workflows/ci.yml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,11 @@ jobs:

steps:
- uses: actions/checkout@v2
- name: Setup redis
uses: shogo82148/actions-setup-redis@v1
with:
redis-version: 6.0
auto-start: "false"
- name: Build
run: cargo build --all --all-targets --verbose
- name: Run tests
Expand All @@ -23,6 +28,11 @@ jobs:

steps:
- uses: actions/checkout@v2
- name: Setup redis
uses: shogo82148/actions-setup-redis@v1
with:
redis-version: 6.0
auto-start: "false"
- name: Build
run: cargo build --all --all-targets --verbose
- name: Run tests
Expand Down
Loading

5 comments on commit 3240281

@stopforumspam
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the docs to state that the member key name is not binary safe and that they have to avoid using { or } when using ASCII names otherwise your json decoder segfaults during loading

@danitseitlin
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stopforumspam Is that something you reproduced and saw happening?

@stopforumspam
Copy link

@stopforumspam stopforumspam commented on 3240281 Mar 2, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, there is an RDB file attached to comments in this thread, and a method to reproduce (in my comments from last week). The RDB will segfault when you load

#20 (comment)

dump.zip https://github.com/danitseitlin/redis-interval-sets/files/8101646/dump.zip

@danitseitlin
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@stopforumspam Cool, thanks for letting me know.
Can we open a new issue on GitHub with the relevance to the specific problem? that way I will be all synced and will try to find a solution :)

@stopforumspam
Copy link

@stopforumspam stopforumspam commented on 3240281 Mar 2, 2022 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.