-
Notifications
You must be signed in to change notification settings - Fork 29
Minor client updates #213
Minor client updates #213
Conversation
@mjm2312 Hi, please notice to the CI failures, once all is passing I will review :) |
…s-sdk-ts into minor-client-updates
@mjm2312 ping? |
hey Dani, sorry for the delay. It seems like relevant tests are passing now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution, added a few comments :)
Another thing, please make sure to point out you're updating the RTS client in the final merged commit :) |
I can squash and merge, and include in the message that it's for RTS and addresses the three points at the top of the PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments, in addition notice some tests failed on the build.
I think it's some tests that broke after the change from String to the custom type in Duplicate Policy. Probably needs a small fix.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! Thanks
np! I don't have write access so not sure I can merge Could you either grant me write access or merge yourself? Thank you :) |
* Enhancement: Adds support to update duplicatePolicy, chunkSize in TS.ALTER calls: [TS.ALTER](https://redis.io/commands/ts.alter/) * Bug Fix: Changes duplicate policy from boolean | undefined to string | undefined: [TS.INFO](https://redis.io/commands/ts.alter/) * Bug Fix: Allows a list of args for TS.QUERYINDEX [TS.QUERYINDEX](https://redis.io/commands/ts.queryindex/)
* Enhancement: Adds support to update duplicatePolicy, chunkSize in TS.ALTER calls: [TS.ALTER](https://redis.io/commands/ts.alter/) * Bug Fix: Changes duplicate policy from boolean | undefined to string | undefined: [TS.INFO](https://redis.io/commands/ts.alter/) * Bug Fix: Allows a list of args for TS.QUERYINDEX [TS.QUERYINDEX](https://redis.io/commands/ts.queryindex/)
Enhancement: Adds support to update duplicatePolicy, chunkSize in TS.ALTER calls: TS.ALTER
Bug Fix: Changes duplicate policy from boolean | undefined to string | undefined: TS.INFO
Bug Fix: Allows a list of args for TS.QUERYINDEX TS.QUERYINDEX