Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace editor-not-null-attribute assertions using NodeErrors with alternatives that don't use NodeErrors #90

Open
Abb4 opened this issue Oct 1, 2023 · 0 comments
Open

Replace editor-not-null-attribute assertions using NodeErrors with alternatives that don't use NodeErrors #90

Abb4 opened this issue Oct 1, 2023 · 0 comments
Labels
milestone candidate Good issues for next milestone QOL Quality of Live

Comments

@Abb4
Copy link
Contributor

Abb4 commented Oct 1, 2023

Currently we throw exceptions if editor properties are not set:

PlayerInteractionArea.AssertEditorPropertySet(nameof(PlayerInteractionArea));
PlayerUi.AssertEditorPropertySet(nameof(PlayerUi));

Currently AssertEditorPropertySet uses Results. But it does not need to. Instead replace it with similar looking method that does not create Results and with a better error message/exception message.
@Abb4 Abb4 added milestone candidate Good issues for next milestone QOL Quality of Live labels Oct 1, 2023
@Abb4 Abb4 mentioned this issue Oct 1, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
milestone candidate Good issues for next milestone QOL Quality of Live
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Abb4