Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed NavigateTowards2dNodes attribute, instead push parent values downwards by searching appropriate component (fixes #20) #25

Merged
merged 1 commit into from
Aug 13, 2023

Conversation

Abb4
Copy link
Contributor

@Abb4 Abb4 commented Aug 10, 2023

  • fixes Verify that scene load issue is gone #20

  • apparently the reference to NavigateTowards2dNodes by NavMesh2DSeeker as an attribute is what caused the error

    • I used the reference in NavMesh2DSeeker to push values set in the editor downstream to the component
    • I implemented the reference that way so that we could configure the scene from the editor and did not have to GetNode to find the component
    • Now I just use GetNode (specifically TryFindNodeInChildrenRecursively helper function)

(Yes it was neither the cashe nor the naming 🙈)

@Abb4 Abb4 self-assigned this Aug 10, 2023
@Abb4 Abb4 force-pushed the fixing-#20-by-removing-circular-reference branch 2 times, most recently from 9f2f394 to c5112f2 Compare August 10, 2023 21:41
…s downwards by searching appropriate component (fixes #20)
@Abb4 Abb4 requested a review from softwaredev101 August 10, 2023 21:43
@Abb4 Abb4 merged commit c6d0bff into main Aug 13, 2023
@Abb4 Abb4 deleted the fixing-#20-by-removing-circular-reference branch August 13, 2023 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Verify that scene load issue is gone
1 participant