Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use RGBA 32-bit draws with kitty protocol #1399

Closed
dankamongmen opened this issue Mar 11, 2021 · 2 comments
Closed

Use RGBA 32-bit draws with kitty protocol #1399

dankamongmen opened this issue Mar 11, 2021 · 2 comments
Assignees
@dankamongmen
Labels
bitmaps bitmapped graphics (sixel, kitty, mmap) enhancement New feature or request
Milestone
2.3.0

Comments

@dankamongmen
Copy link
Owner

See #1395 for more details. In order to draw both atop and below kitty graphics, we're likely going to need to use the 32-bit RGBA technique, and A-out the regions where we want to draw. We'll certainly need to in order to draw below.
@dankamongmen dankamongmen added the enhancement New feature or request label Mar 11, 2021
@dankamongmen dankamongmen added this to the 2.3.0 milestone Mar 11, 2021
@dankamongmen dankamongmen self-assigned this Mar 11, 2021
@dankamongmen
Copy link
Owner Author

mostly working, but it's clearly a slightly different output image. old/new follow:
2021-03-11-175004_802x1417_scrot
2021-03-11-175122_802x1417_scrot

there shouldn't be any transparency in covid19.jpg, and yet the new code is definitely drawing with some transparency, it would seem...

@dankamongmen
Copy link
Owner Author

got it working, bug in my code, w00t!

dankamongmen added a commit that referenced this issue Mar 11, 2021
@dankamongmen
kitty: use 32-bit RGBA draws for transparency #1399
660d25e
@dankamongmen dankamongmen added the bitmaps bitmapped graphics (sixel, kitty, mmap) label Mar 24, 2021
@dankamongmen dankamongmen modified the milestones: 3.0.0, 2.3.0 Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dankamongmen dankamongmen

Labels
bitmaps bitmapped graphics (sixel, kitty, mmap) enhancement New feature or request
Projects
None yet
Milestone
2.3.0
Development

No branches or pull requests
1 participant
@dankamongmen