Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

line discipline signals broken in XTMODKEYS #2537

Closed
dankamongmen opened this issue Jan 8, 2022 · 8 comments
Closed

line discipline signals broken in XTMODKEYS #2537

dankamongmen opened this issue Jan 8, 2022 · 8 comments
Assignees
Labels
bug Something isn't working input readin' dem bytes
Milestone

Comments

@dankamongmen
Copy link
Owner

Got the latest contour building, and we're seeing some nasty problems. cli1 can only read two inputs before it ceases. notcurses-input bleeds a tremendous amount of what looks like palette replies through.

@dankamongmen dankamongmen added the bug Something isn't working label Jan 8, 2022
@dankamongmen dankamongmen added this to the 3.1.0 milestone Jan 8, 2022
@dankamongmen dankamongmen self-assigned this Jan 8, 2022
@dankamongmen
Copy link
Owner Author

the cli1 problem also seems to be happening on XTerm.

@dankamongmen
Copy link
Owner Author

the cli1 problem also seems to be happening on XTerm.

and WezTerm =\

@dankamongmen
Copy link
Owner Author

so when we're in this state, ctrl-c prompts a "press any key, q to quit" message (as a normal key would), but doesn't exit (as it normally does). interesting.

@dankamongmen
Copy link
Owner Author

actually, hrmm, it seems any use of ctrl results in an event?

@dankamongmen
Copy link
Owner Author

oh hrmm does XTMODKEYS essentially go into linesigs disabled (raw) mode? that would definitely explain the latter issue.

@dankamongmen
Copy link
Owner Author

ok, the ctrl+c and friends problem is remedied

@dankamongmen
Copy link
Owner Author

hmmm this doesn't happen to notcurses-input, just cli1, so it's pretty clearly an instance of the inputready fd not working. maybe this is #2216, and we've just always been testing in kitty? urk.

@dankamongmen dankamongmen changed the title cli1 can only read two inputs, notcurses-input bleeds many inputs in contour line discipline signals broken in XTMODKEYS Jan 8, 2022
@dankamongmen dankamongmen added the input readin' dem bytes label Jan 8, 2022
@dankamongmen
Copy link
Owner Author

yeah, if i pull the poll() out of cli1, things work just fine. alright, good, it looks like we might get to #2216 now. calling this closed for handling the line discipline signals.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working input readin' dem bytes
Projects
None yet
Development

No branches or pull requests

1 participant