Skip to content

Conversation

@firewave
Copy link
Collaborator

@firewave firewave commented Dec 7, 2022

Scanning mame_regtest with DISABLE_VALUEFLOW=1 and --enable=all --inconclusive

Clang 14 2,015,012,279 -> 2,012,304,007
GCC 12 1,919,686,733 -> 1,916,926,979

Scanning cli/filelister.cpp with DISABLE_VALUEFLOW=1 and --enable=all --inconclusive -Ilib -D__GNUC__

Clang 14 88,461,658 -> 87,596,261
GCC 12 87,505,725 -> 86,581,855

@firewave
Copy link
Collaborator Author

firewave commented Dec 7, 2022

Strangely this triggers an additional warning:

cli/cppcheckexecutor.cpp:521:0: style: The function 'getExceptionOutput' is never used. [unusedFunction]
FILE* CppCheckExecutor::getExceptionOutput()
^

@firewave
Copy link
Collaborator Author

firewave commented Dec 7, 2022

Strangely this triggers an additional warning:

cli/cppcheckexecutor.cpp:521:0: style: The function 'getExceptionOutput' is never used. [unusedFunction]
FILE* CppCheckExecutor::getExceptionOutput()
^

Caused by a missing return omitted in danmar/simplecpp#276. Fixed in danmar/simplecpp#281.

This highlights that simplecpp and cppcheck are completely lacking tests utilizing header files.

@firewave
Copy link
Collaborator Author

firewave commented Dec 7, 2022

It is also weird that it did not produce any missingInclude warnings in the selfcheck. I was getting those with simplecpp. Something to look into as well.

@firewave firewave marked this pull request as ready for review December 8, 2022 19:30
@orbitcowboy orbitcowboy merged commit bdee2ff into danmar:main Dec 9, 2022
@firewave firewave deleted the simplecpp branch December 9, 2022 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants