avoid unnecessary copy in openHeader() - detected by upcoming clang-tidy check performance-unnecessary-copy-on-last-use
#276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-tidy check `performance-unnecessary-copy-on-last-use`
firewave
commented
Dec 7, 2022
| ret = openHeaderRelative(f, sourcefile, header); | ||
| return ret.empty() ? openHeaderIncludePath(f, dui, header) : ret; | ||
| if (ret.empty()) | ||
| openHeaderIncludePath(f, dui, header); |
There was a problem hiding this comment.
Missing the return.
Like I pointed out in other PRs we need have tests which use include files (which need to exist on the filesystem).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I looks like a false positive but using a non-POD variable in a ternary causes it to be copied - see https://reviews.llvm.org/D137205#3939210.
Since simplecpp also supports pre-C++11 standards
std:move()could not be used and I refactored the code instead getting rid of the ternaries.