Skip to content

Conversation

firewave
Copy link
Collaborator

@firewave firewave commented Dec 30, 2022

This is just good practice. But it also fixes issues with running .sh files when using a repo checking out on Windows within WSL as well as unexpected EOL changes in Visual Studio-related files as seen in #4652.

No files are changed. By checking Hide whitespaces under the gear when viewing the changes you can see that just .gitattributes was added.

I also added some common extensions we are not (yet) using in the repo like .ps1 and .pdf.

@firewave
Copy link
Collaborator Author

See https://git-scm.com/docs/gitattributes for documentation on this.

@firewave
Copy link
Collaborator Author

firewave commented Dec 30, 2022

The Visual Studio files probably don't need to be treated as CRLF since Visual Studio is being able to read them regardless of EOL but the dmake code which updates the file expects them to have those endings..

@firewave firewave marked this pull request as ready for review December 30, 2022 19:07
@danmar danmar merged commit 0c95971 into danmar:main Dec 30, 2022
@firewave firewave deleted the gitattr branch December 30, 2022 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants