make sure executors are only used in the intended context / TestSuppressions cleanups
#4963
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Still not finished. Also the suppression tests need to be extended to highlight the issues we encounter in our selfcheck. I removed the CI files so this does not trigger a build to ease things. |
|
It turns out there is no "problem" with the suppressions. The tests were just faulty and I misunderstood https://trac.cppcheck.net/ticket/10104 as well as the output of #3090. |
firewave
changed the title
TestSuppressions cleanups
|
The executor-specific tests should probably be moved into the executor tests but that would lead to unnecessary code duplication. We can do that after the executors share the same code and no longer need separate tests. |
chrchr-github
approved these changes
Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This exposes tests which were using executors with the wrong amount of jobs leading to code paths which cannot occur in application code.