Refactoring: Break out loadLibraries() function. #5024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No functional change is intended. This is a preparation to make qml handling work again
danmar
force-pushed
the
qml-refactoring-1
branch
from
d1acc41 to
47800e0
Compare
|
Here's a ticket regarding the duplicated builds for your PRs: open-telemetry/opentelemetry-python#1370. Unfortunately there's no solution for our case in there. |
|
I think we need to limit the actions on push to the following branches: on:
push:
branches:
- main
- 'releases/**'
pull_request:https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#using-filters So it will keep the current behavior on PRs but don't also don't fire on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No functional change is intended.
This is a preparation to make qml handling work again