std.cfg: remove wrong macro replacements for UINT32_C etc. #5527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ements should be platform dependent. And I am skeptic that i.e. UINT32_C(10L) should be replaced with 10LUL i.e. making it a long long.
Owner
Author
Collaborator
|
This will break existing code and we have probably have lots of such cases where wrong value are being used. See #5414 for work going more towards the platform stuff. Also we need proper tests for this. We also have lots of fixed/implementation-based stuff in our configurations which should not be in-there as they do not reflect what is actually used on the system. |
Collaborator
Okay, breakage is unlikely as this was previously not defines for all configuration but only avr. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The replacements should be platform dependent. And I am skeptic that i.e. UINT32_C(10L) should be replaced with 10LUL i.e. making it a long long.