fixed #12145 - provided order of source files is not preserved #5625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is also required to move the file sorting based on the markup extensions to the shared code. |
firewave
commented
Nov 5, 2023
| else { | ||
| const int err = errno; | ||
| return "could not stat file '" + new_path + "' (errno: " + std::to_string(err) + ")"; | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| filesSorted.sort([](const decltype(filesSorted)::value_type& a, const decltype(filesSorted)::value_type& b) { |
There was a problem hiding this comment.
The files inside the folder still need to be sorted as the order retrieved from the filesystem is random.
I did not add an explicit test for this as this is implicitly tested by dmake. The order of the files were different in the generated files before I added the sorting.
danmar
reviewed
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.